Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new block format support for eosmechanics #35

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Added new block format support for eosmechanics #35

wants to merge 11 commits into from

Conversation

chamorin
Copy link
Contributor

@chamorin chamorin commented Sep 19, 2024 •
edited
Loading

I'm still missing the code to handle pending_schedule since it's no longer there in the new block format. Because of that:

// If there is no pending schedule, then there is no schedule change
if pending_schedule.is_empty() {
    return Ok(Default::default());
}

will always return empty for map_schedule_change

@chamorin chamorin self-assigned this Sep 19, 2024
@YaroShkvorets
Copy link
Member

LGTM

@YaroShkvorets
Copy link
Member

Actually no, it doesn't produce any schedule changes at all now. Need to find a way a better way to detect schedule change.

@YaroShkvorets
Copy link
Member

@DenisCarriere when you have time can you look into it?

@chamorin
Copy link
Contributor Author

I added a check for pending_schedule, so if it's the new block format it will not take pending_schedule into account. If it's the new block format it will only rely on active_schedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisCarriere DenisCarriere Awaiting requested review from DenisCarriere

@YaroShkvorets YaroShkvorets Awaiting requested review from YaroShkvorets

Assignees

@chamorin chamorin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chamorin @YaroShkvorets @DenisCarriere